Are code reviews dreaded within your team? Your...
January 11th, 2021
Are code reviews dreaded within your team? Your...
Are code reviews dreaded within your team? Your team may not be approaching these in the best way…" "" "Putting one’s work up for critique is always stressful. A judgment of one’s work feels personal. While reviews are difficult no matter the field, code reviews are particularly harsh if the right team environment is not in place. The value of code review is all about collaboration and ensuring the best possible code gets submitted. " "" "Feedback must be constructive when something is found that needs fixing, such that the code author does not feel attacked; they feel helped. Instead of declaring something is wrong, asking questions yields a far more positive outcome." "" "Especially because 80% of the time, the author will agree with the feedback! It’s much more comfortable and feels much better to say, “oh yea, nice catch!” to “was this logging just for debugging, should we remove it?” vs. “I was going to remove it, doing so now” as a response to “There’s no need for this logging, get rid of it.” As a reviewer, assume good intent from your peers. We’re all moving fast, and things slip; that’s one of the purposes of code review. It’s not a place to rip other people’s work apart; it’s a place to help other people further improve their work. #bendevtip
Original post on LinkedIn